At Fri, 11 Jun 2021 15:23:41 +0900, Michael Paquier <mich...@paquier.xyz> wrote in > On Thu, Jun 10, 2021 at 11:29:30PM +0200, Fabien COELHO wrote: > > + /* flush remaining stats */ > > + if (!logged && latency == 0.0) > > + logAgg(logfile, agg); > > You are right, this is missing the final stats. Why the choice of > latency here for the check? That's just to make the difference > between the case where doLog() is called while processing the > benchmark for the end of the transaction and the case where doLog() is > called once a thread ends, no? Wouldn't it be better to do a final > push of the states once a thread reaches CSTATE_FINISHED or > CSTATE_ABORTED instead?
Doesn't threadRun already doing that? -- Kyotaro Horiguchi NTT Open Source Software Center
