> On Mon, Jun 21, 2021 at 12:50 PM Bruce Momjian <br...@momjian.us> wrote: >> >> On Tue, Jun 15, 2021 at 12:01:00PM +0900, Michael Paquier wrote: >> > On Tue, Jun 15, 2021 at 11:49:21AM +0900, Masahiko Sawada wrote: >> > > On Tue, Jun 15, 2021 at 10:36 AM Bruce Momjian <br...@momjian.us> wrote: >> > >> OK, but I need more information on how users will see a difference based >> > >> on this commit: >> > >> > +1. That would be good to have in the release notes. >> > >> > > I think that since with this commit the server on Windows can handle a >> > > file over 4GB, COPY FROM loading data from an over 4GB file and >> > > pg_dump dumping a large table work now. >> > >> > Segment files or WAL files larger than 4GB also gain from that. >> > Anything for which we may finish to do a stat() on benefits from this >> > change if running on Windows. For pg_dump, a workaround in PG <= 13 >> > was to use --no-sync as the stat() failure came from files with a size >> > larger than 4GB. That's rather sad as that means sacrifying >> > durability for more usability :( >> >> OK, I went with this text and put it in the Source Code section since it >> applies to several layers of Postgres. > > Thanks! > > I got the parse error after applying the patch: > > release-14.sgml:3562: parser error : Input is not proper UTF-8, > indicate encoding ! > Bytes: 0xE9 0x20 0x53 0x61 > (Juan Jos Santamara Flecha) > ^ > > Is that a problem with my environment?
Me too. I think the problem is, Bruce's patch is encoded in ISO-8859-1, not UTF-8. As far as I know PostgreSQL never encodes *.sgml files in ISO-8859-1. Anyway, attached is the Bruce's patch encoded in UTF-8. This works for me. My guess is, when Bruce attached the file, his MUA automatically changed the file encoding from UTF-8 to ISO-8859-1 (it could happen in many MUA). Also that's the reason why he does not see the problem while compiling the sgml files. In his environment release-14.sgml is encoded in UTF-8, I guess. To prevent the problem next time, it's better to change the mime type of the attached file to Application/Octet-Stream. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
master.diff
Description: Binary data
