On Sat, Jun 26, 2021 at 11:01:07AM -0400, Andrew Dunstan wrote: > On 6/26/21 2:47 AM, Fabien COELHO wrote: >> However, if slurp_file fails it raises an exception and aborts the >> whole TAP unexpectedly, which is pretty unclean. So I'd suggest to >> keep the eval, as attached. I tested it by changing the file name so >> that the slurp fails. > > Seem quite unnecessary. We haven't found that to be an issue elsewhere > in the code where slurp_file is used. And in the present case we know > the file exists because we got its name from list_files().
Agreed. That's an exchange between a hard failure mid-test and a failure while letting the whole test run. Here, we expect the test to find the log file all the time, so a hard failure does not sound like a bad thing to me either. -- Michael
signature.asc
Description: PGP signature
