On Mon, Jul 5, 2021 at 3:16 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Jul 1, 2021 at 6:31 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > On Thu, Jul 1, 2021 at 12:56 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > Instead of using the syntax "ALTER SUBSCRIPTION name SET SKIP > TRANSACTION Iconst", isn't it better to use it as a subscription > option like Mark has done for his patch (disable_on_error)? > > I am slightly nervous about this way of allowing the user to skip the > errors because if it is not used carefully then it can easily lead to > inconsistent data on the subscriber. I agree that as only superusers > will be allowed to use this option and we can document clearly the > side-effects, the risk could be reduced but is that sufficient? >
I see that users can create a similar effect by using pg_replication_origin_advance() and it is mentioned in the docs that careless use of this function can lead to inconsistently replicated data. So, this new way doesn't seem to be any more dangerous than what we already have. -- With Regards, Amit Kapila.
