I have reviewed the v9 patch and my feedback comments are below: //////////
1. Apply v9 gave multiple whitespace warnings $ git apply v9-0001-Skip-empty-transactions-for-logical-replication.patch v9-0001-Skip-empty-transactions-for-logical-replication.patch:479: indent with spaces. * If the BEGIN PREPARE was not yet sent, then it means there were no v9-0001-Skip-empty-transactions-for-logical-replication.patch:480: indent with spaces. * relevant changes encountered, so we can skip the ROLLBACK PREPARED v9-0001-Skip-empty-transactions-for-logical-replication.patch:481: indent with spaces. * messsage too. v9-0001-Skip-empty-transactions-for-logical-replication.patch:482: indent with spaces. */ warning: 4 lines add whitespace errors. ------ 2. Commit comment - wording pgoutput will also skip COMMIT PREPARED and ROLLBACK PREPARED messages for transactions which were skipped. => Is that correct? Or did you mean to say: AFTER pgoutput will also skip COMMIT PREPARED and ROLLBACK PREPARED messages for transactions that are empty. ------ 3. src/backend/replication/pgoutput/pgoutput.c - typo + /* + * If the BEGIN PREPARE was not yet sent, then it means there were no + * relevant changes encountered, so we can skip the COMMIT PREPARED + * messsage too. + */ Typo: "messsage" --> "message" (NOTE this same typo is in 2 places) ------ Kind Regards, Peter Smith. Fujitsu Australia