On Fri, Jul 23, 2021 at 10:26 AM Greg Nancarrow <gregn4...@gmail.com> wrote: > > On Thu, Jul 22, 2021 at 11:37 PM Ajin Cherian <itsa...@gmail.com> wrote: > > > > I have some minor comments on the v9 patch: > > (1) Several whitespace warnings on patch application >
Fixed. > (2) Suggested patch comment change: > > BEFORE: > The current logical replication behaviour is to send every transaction to > subscriber even though the transaction is empty (because it does not > AFTER: > The current logical replication behaviour is to send every transaction to > subscriber even though the transaction might be empty (because it does not > Changed accordingly. > (3) Comment needed for added struct defn: > > typedef struct PGOutputTxnData > Added. > (4) Improve comment. > > Can you add a comma (or add words) in the below sentence, so we know > how to read it? > Updated. regards, Ajin Cherian Fujitsu Australia
v10-0001-Skip-empty-transactions-for-logical-replication.patch
Description: Binary data
