On Tue, 27 Jul 2021 at 15:08, Greg Nancarrow <gregn4...@gmail.com> wrote: > > On Tue, Jul 27, 2021 at 12:42 PM Michael Paquier <mich...@paquier.xyz> wrote: > > > > #include "common/int.h" > > +#include "d2s_intrinsics.h" > > Er, are you sure about this part? The first version of the patch did > > that in a different, also incorrect, way. > > Er, I was just trying to help out, so at least the patch could be > applied (whether the patch has merit is a different story). > Are you saying that it's incorrect to include that header file in this > source, or that's the wrong way to do it? (i.e. it's wrong to adjust > the makefile include path to pickup the location where that header is > located and use #include "<header>"? That header is in src/common, > which is not on the default include path). > The method I used certainly works, but you have objections? > Can you clarify what you say is incorrect?
I think the mistake is that the header file is not in src/include/common. For some reason, it's ended up with all the .c files in src/common. I imagine Andrew did this because he didn't ever expect anything else to have a use for these. He indicates that in [1]. Maybe Andrew can confirm? [1] https://www.postgresql.org/message-id/87mup9192t.fsf%40news-spur.riddles.org.uk David