On Fri, Aug 6, 2021 at 3:33 PM tanghy.f...@fujitsu.com
<tanghy.f...@fujitsu.com> wrote:
>
> Hi
>
> I saw some inaccurate comments for AlterPublicationStmt structure when
> reviewing patches related to publication[1].
>
> The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE',
> but the comments only say 'ADD/DROP'. How about add 'SET' to the comments?
>
> typedef struct AlterPublicationStmt
> {
> NodeTag type;
> char *pubname; /* Name of the publication */
>
> /* parameters used for ALTER PUBLICATION ... WITH */
> List *options; /* List of DefElem nodes */
>
> /* parameters used for ALTER PUBLICATION ... ADD/DROP TABLE */
> List *tables; /* List of tables to add/drop
> */
> bool for_all_tables; /* Special publication for all tables
> in db */
> DefElemAction tableAction; /* What action to perform with the
> tables */
> } AlterPublicationStmt;
>
> It's also a comment improvement, so I add this change to this patch.
Thanks for the updated patch, your changes look good to me. You might
want to include the commit message in the patch, that will be useful.
Regards,
Vignesh
