On Thu, Aug 12, 2021 at 9:18 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > A minor comment on the 0001 patch: In the message I think that using > > "ID" would look better than lowercase "id" and AFAICS it's more > > consistent with existing messages. > > > > + appendStringInfo(&buf, _(" in transaction id %u with commit timestamp > > %s"), > > > > You have a point but I think in this case it might look a bit odd as > we have another field 'commit timestamp' after that which is > lowercase. >
I did a quick search and I couldn't find any other messages in the Postgres code that use "transaction id", but I could find some that use "transaction ID" and "transaction identifier". Regards, Greg Nancarrow Fujitsu Australia