On Wed, Aug 25, 2021 at 08:23:04PM -0400, Alvaro Herrera wrote: > On 2021-Aug-25, Peter Geoghegan wrote: >> This seems like a release housekeeping task to me. I'll come up with >> a patch targeting 14 and master in a few days. > > Agreed, thanks.
Sorry for the late reply here. Indeed, I can see your point to move the buffer usage a bit down, grouped with the other information related to I/O. Moving down this information gives the attached. If you wish to do that yourself, that's fine by me, of course. Saying this, an ANALYZE-only command does amvacuumcleanup() for all the indexes and the stats exist. I am not saying that we should do that for 14 as that's too late, but we could consider adding the index information also in this case in 15~? -- Michael
diff --git a/src/backend/access/heap/vacuumlazy.c
b/src/backend/access/heap/vacuumlazy.c
index 334d8a2aa7..a40d4943a3 100644
--- a/src/backend/access/heap/vacuumlazy.c
+++ b/src/backend/access/heap/vacuumlazy.c
@@ -796,11 +796,6 @@ heap_vacuum_rel(Relation rel, VacuumParams *params,
(long long)
vacrel->new_rel_tuples,
(long long)
vacrel->new_dead_tuples,
OldestXmin);
- appendStringInfo(&buf,
- _("buffer usage: %lld
hits, %lld misses, %lld dirtied\n"),
- (long long)
VacuumPageHit,
- (long long)
VacuumPageMiss,
- (long long)
VacuumPageDirty);
if (vacrel->rel_pages > 0)
{
BlockNumber orig_rel_pages;
@@ -844,6 +839,11 @@ heap_vacuum_rel(Relation rel, VacuumParams *params,
istat->pages_deleted,
istat->pages_free);
}
+ appendStringInfo(&buf,
+ _("buffer usage: %lld
hits, %lld misses, %lld dirtied\n"),
+ (long long)
VacuumPageHit,
+ (long long)
VacuumPageMiss,
+ (long long)
VacuumPageDirty);
appendStringInfo(&buf, _("avg read rate: %.3f MB/s, avg
write rate: %.3f MB/s\n"),
read_rate, write_rate);
if (track_io_timing)
signature.asc
Description: PGP signature
