Hi, We have two static check_permissions functions (one in slotfuncs.c another in logicalfuncs.c) with the same name and same code for checking the privileges for using replication slots. Why can't we have a single function CheckReplicationSlotPermissions in slot.c? This way, we can get rid of redundant code. Attaching a patch for it.
Thoughts? Regards, Bharath Rupireddy.
v1-0001-replication-slots-remove-duplicate-code-for-check.patch
Description: Binary data