On Mon, Sep 20, 2021 at 2:38 AM Daniel Gustafsson <dan...@yesql.se> wrote: > > Rebased on top of HEAD with off-list comment fixes by Kevin Burke. >
Hello Daniel, I've been playing with your patch on Mac (OS 11.6 Big Sur) and have run into a couple of issues so far. 1. I get 7 warnings while running make (truncated): cryptohash_nss.c:101:21: warning: implicit conversion from enumeration type 'SECOidTag' to different enumeration type 'HASH_HashType' [-Wenum-conversion] ctx->hash_type = SEC_OID_SHA1; ~ ^~~~~~~~~~~~ ... cryptohash_nss.c:134:34: warning: implicit conversion from enumeration type 'HASH_HashType' to different enumeration type 'SECOidTag' [-Wenum-conversion] hash = SECOID_FindOIDByTag(ctx->hash_type); ~~~~~~~~~~~~~~~~~~~ ~~~~~^~~~~~~~~ 7 warnings generated. 2. libpq-refs-stamp fails -- it appears an exit is being injected into libpq on Mac Notes about my environment: I've installed nss via homebrew (at version 3.70) and linked it. Cheers, Rachel