"Warren Turkal" <[EMAIL PROTECTED]> writes: > So...in the vein of my last mail, I have tried to create another patch > for refactoring out some of the HAVE_INT64_TIMESTAMP ifdefs in the > code in timestamp.c. I have attached the patch. Please let me know if > this patch is acceptable and what I can do to continue this effort.
Hmm, PackedTime seems like a fairly random name for the type --- there's not anything particularly "packed" about it IMO. I'm a bit inclined to suggest just using the Timestamp typedef. I guess though that there's some risk of confusion between values that actually are "timestamp without time zone" and values that need the same representation but aren't actually intended to represent a specific point in time. Maybe "TimeOffset" or "TimeValue" or something like that? Other than the name game, I think you're headed in the right direction. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match