"Tom Lane" <[EMAIL PROTECTED]> writes: > "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: >> Neil Conway wrote: >>> If we're just updating MyProc->xmin, we only need to acquire >>> ProcArrayLock in shared mode, right? > >> In fact, do you need a lock at all? > > I think you probably do. GetSnapshotData needs to be confident that the > global xmin it computes is <= the xmin that any other backend might be > about to store into its MyProc->xmin; how can you ensure that if there's > no locking happening?
Surely xmin would only ever advance? How can removing snapshots cause xmin to retreat at all, let alone behind the gloal xmin GetSnapshotData calculated? > Now the way I'd been envisioning this would work is that whenever the > number of active snapshots goes to zero, we clear MyProc->xmin, and > that probably could be done without a lock. Then the next time we do > GetSnapshotData, it would compute and store a new MyProc->xmin > (this would be the same activity that we currently think of as "setting > the serializable snapshot"). So you don't need any more locking than > already exists. It's the same locking in theory from the point of view of where in the code the locking happens. But I don't think it's the same locking in practice from the point of view of how much wall-clock time passes between locks. Consider a data loading job which has millions of INSERT statements in a file. Currently if you put them all in a transaction it takes a single snapshot and runs them all with the same snapshot. If you reset xmin whenever you have no live snapshots then that job would be doing that between every INSERT statement. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Get trained by Bruce Momjian - ask me about EnterpriseDB's PostgreSQL training! -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
