Tom Lane wrote: > I wrote: > > Okay, but you failed to correctly reproduce the conditions for > > closing the old file. > > A more bulletproof solution might involve passing sync_method to > get_sync_bit as an explicit parameter, and then the assign hook > could do > if (get_sync_bit(sync_method) != > get_sync_bit(new_sync_method)) XLogFileClose();
Right, but I still need the other part of the check, right? This one still fails the same check as my patch, no? Because I assume the hole you found there was that get_sync_bit() will return 0 for two different sync methods as long as none of them are O_SYNC or O_DSYNC... //Magnus -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers