On Thu, 2008-07-24 at 19:11 -0400, Tom Lane wrote: > There's some fairly squirrely logic in pg_dump/pg_restore that tries to > detect whether it's doing a data-only operation, ie, no schema > information is to be dumped or restored. The reason it wants to > know this is to decide whether to enable the --disable-triggers > code. However, since --disable-triggers is off by default and has > to be manually requested, I'm not sure why we've got all this extra > complexity in there. (Actually, I'm sure the reason is that that > code predates the existence of the --disable-triggers switch, but > anyway...) > > Simon's patch to split up --schema-only into two switches has broken > this logic, but I'm inclined to just rip it out rather than trying > to fix it. If the user says --disable-triggers, he should get > trigger disable commands around the data part of the dump, no matter > what he said or didn't say about schema dumping.
Agreed. Thanks for the clear thinking. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
