2008/10/2 Tom Lane <[EMAIL PROTECTED]>: > "Hitoshi Harada" <[EMAIL PROTECTED]> writes: >>> I hadn't realized that this would be relevant to window functions. >>> Now that I know that, I propose fixing tuplestore for multiple >>> positions and committing it separately, before I go back to the CTE >>> patch. Then Hitoshi-san will have something he can work with too. > >> Yes, tuplestore multiple positioning will give the greate help to the >> window function. Ideally, it is better that tuplestore'd have all the >> positions and have some kind of capability to discard old rows so that >> it can stay in TSS_MEM, which helps window function's sliding frame. > > Okay, there's a patch in CVS HEAD that works this way. Let me know if > it needs further tweaking for your purposes. > > regards, tom lane >
Hmm, I've looked over the patch. Logically window functions can access arbitrary rows that have been stored in a frame. Thus I had thought tuplestore should hold all the positions and allow arbitrary random access indicated by integer. Maybe those functionalities can be abstracted by the window function API itself. For this matter it seems that you'd better to look at my future patch. Everything else is great deal. By improving tuplestore_trim(), sliding frame will be performed better than I'd thought. Regards, -- Hitoshi Harada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
