Alvaro Herrera wrote: > Log Message: > ----------- > Properly access a buffer's LSN using existing access macros instead of abusing > knowledge of page layout.
Hmm, I just noticed this comment in bufpage.h (which was also in Jonah's patch) :-( typedef struct PageHeaderData { /* XXX LSN is member of *any* block, not only page-organized ones */ ... So I'm now wondering if the above patch is really correct. It'll of course work, but is it appropriate? -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers