On Thu, 2008-10-23 at 13:40 +0300, Heikki Linnakangas wrote: > Simon Riggs wrote: > > The patch isn't ready to apply standalone because we need to include the > > changes to XidInMVCCSnapshot() also, which would take a little while to > > extract. Let me know if that is worth producing a standalone patch for. > > FWIW, this patch becomes a lot simpler if you don't change the function > signature, and don't move the SubtransSetParent() call.
Yeh, I'm trying to judge between trying to be simple and trying to be neat. Whichever one I pick, I seem to be wrong. :-) But I begin, perhaps too slowly, to understand that this is a natural part of review itself, not really a problem. Thanks for your help. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
