Tom Lane wrote:

> That is, that's true as long as the filesystem copy in fact pushed
> everything to disk.  copydir() does an fsync() on each file it copies,
> so I think we have done as much as we can to protect the data being
> copied, but I wonder if anyone feels it's too dangerous?

Do we need to fsync the directory itself?  My fsync(2) manpage says

       Calling  fsync()  does  not  necessarily ensure that the entry in the 
directory
       containing the file has also reached disk.  For that an explicit fsync() 
 on  a
       file descriptor for the directory is also needed.


-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to