On Mon, Nov 3, 2008 at 8:41 PM, ITAGAKI Takahiro <[EMAIL PROTECTED]> wrote: > Hello, Saito-san: > > "Hiroshi Saito" <[EMAIL PROTECTED]> wrote: >> next patch is this. > > I'm reviewing your patch and cleanup some parts:
i'm confused, original patch has this signature: + conv_strftime(char *src, size_t len, const char *format, const struct tm *tm) your's has: +strftime_win32(char *dst, size_t dstlen, const char *format, const struct tm *tm you change all src for dst, just a variable name decision but a radical one... why was that (i honestly doesn't understand this patch very well ;)? -- Atentamente, Jaime Casanova Soporte y capacitación de PostgreSQL AsesorÃa y desarrollo de sistemas Guayaquil - Ecuador Cel. +59387171157 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
