Hi,

Who is in charge of pg_filedump now?

I noticed that the latest version (for 8.3) does not play nice with
HEAD, because of changes in ControlFileData.  The attached patch fixes
that, allowing it to compile.

I didn't look if there were other changes needed for it to actually
work; any clues?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
*** pg_filedump.c.orig	2008-02-28 11:12:21.000000000 -0300
--- pg_filedump.c	2008-11-13 13:55:11.000000000 -0300
***************
*** 1170,1178 ****
  	      "           Maximum Index Keys: %u\n"
  	      "             TOAST Chunk Size: %u\n"
  	      "   Date and Time Type Storage: %s\n"
! 	      "         Locale Buffer Length: %u\n"
! 	      "                   lc_collate: %s\n"
! 	      "                     lc_ctype: %s\n\n",
  	      EQ_CRC32 (crcLocal,
  			controlData->crc) ? "Correct" : "Not Correct",
  	      controlData->pg_control_version,
--- 1170,1177 ----
  	      "           Maximum Index Keys: %u\n"
  	      "             TOAST Chunk Size: %u\n"
  	      "   Date and Time Type Storage: %s\n"
! 	      "     float4 parameter passing: %s\n"
! 	      "     float8 parameter passing: %s\n\n",
  	      EQ_CRC32 (crcLocal,
  			controlData->crc) ? "Correct" : "Not Correct",
  	      controlData->pg_control_version,
***************
*** 1204,1212 ****
  	      controlData->toast_max_chunk_size,
  	      (controlData->enableIntTimes ?
  	       "64 bit Integers" : "Floating Point"),
! 	      controlData->localeBuflen,
! 	      controlData->lc_collate,
! 	      controlData->lc_ctype);
      }
    else
      {
--- 1203,1210 ----
  	      controlData->toast_max_chunk_size,
  	      (controlData->enableIntTimes ?
  	       "64 bit Integers" : "Floating Point"),
! 	      controlData->float4ByVal ? "by value" : "by reference",
! 	      controlData->float8ByVal ? "by value" : "by reference");
      }
    else
      {
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to