Martin Pihlak <[EMAIL PROTECTED]> writes: > ITAGAKI Takahiro wrote: >>> But is the idea of extending QueryDesc generally acceptable? Is it OK >>> to make a copy of the query string? >> >> The only thing I'm worried about is that QueryDesc lives longer than >> its queryText. Can I assume it never occurs?
> I just finished validating this -- it seems OK. All of the query strings > that make it to CreateQueryDesc are either pstrdup-ed to Portal, in long > lived memory context or just literals. So no need to make extra copies :) I'm trying to figure out what is the status of this patch? I'm not sure if there's any point in applying it, when contrib/pg_stat_statements hasn't been updated to make use of it. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers