Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> Since fnmatch and the #define's are supposed to be provided by >>> <fnmatch.h>, I think you should probably put the substitute definitions >>> in a substitute fnmatch.h, not port.h, to avoid that risk. > >> Do we have an example where we do that before? I assume there is some >> autoconfy way to make that include file only "appear" in the include >> path if the system one doesn't exist or is broken? > > Not really. I'd suggest making the callers do something like > > #ifdef HAVE_FNMATCH > #include <fnmatch.h> > #else > #include "port/pg_fnmatch.h" > #endif
How's that actually different from the #ifdef HAVE_FNMATCH #include <fnmatch.h> <-- happens in fe-secure.c #else #define .... <-- happens in port.h #endif If HAVE_FNMATCH isn't set, we still have the same problem, no? //Magnus -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
