Agreed. I borrowed WAL parsing code from XLogdump and I think WAL parsing should be another candidate.
2008/12/3 Fujii Masao <[EMAIL PROTECTED]>: > Hi, > > On Thu, Nov 27, 2008 at 9:04 PM, Koichi Suzuki <[EMAIL PROTECTED]> wrote: >> Please find enclosed a revised version of pg_readahead and a patch to >> invoke pg_readahead. > > Some similar functions are in xlog.c and pg_readahead.c (for example, > RecordIsValid). I think that we should unify them as a common function, > which helps to develop the tool (for example, xlogdump) treating WAL in > the future. > > Regards, > > -- > Fujii Masao > NIPPON TELEGRAPH AND TELEPHONE CORPORATION > NTT Open Source Software Center > -- ------ Koichi Suzuki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
