Magnus Hagander wrote: > Bruce Momjian wrote: > > Martin Zaun wrote: > >> 4. Issue: missing break in switch, silent override of '-l' argument? > >> > >> This behaviour has been in there before and is not addresses by the > >> patch: The user-selected Win32 "mklink" command mode is never applied > >> due to a missing 'break' in CustomizableInitialize(): > >> > >> switch (restoreCommandType) > >> { > >> case RESTORE_COMMAND_WIN32_MKLINK: > >> SET_RESTORE_COMMAND("mklink", WALFilePath, xlogFilePath); > >> case RESTORE_COMMAND_WIN32_COPY: > >> SET_RESTORE_COMMAND("copy", WALFilePath, xlogFilePath); > >> break; > > > > I have added the missing 'break' to CVS HEAD; thanks. > > Why no backpatch to 8.3? Seems like a clear bugfix to me.
I knew that was going to be asked. At this point I am pulling comments from rejected patches into CVS commits; these are not even submitted patches. I am not comfortable backpatching anything when using that system because obviously no one else even cared enough to submit a patch for it, let alone test it. If someone wants to batckpatch this or submit a patch to be backpatched, that is fine. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers