A small correction to this patch: this is needed because otherwise the
autovac code to parse the option becomes all tangled; this avoids having
to invent special values for "use the default value", and it also avoid
having the default value stored elsewhere in the code than in the
reloptions table.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
diff -u src/backend/access/common/reloptions.c src/backend/access/common/reloptions.c
--- src/backend/access/common/reloptions.c 19 Dec 2008 21:54:32 -0000
+++ src/backend/access/common/reloptions.c 20 Dec 2008 03:37:36 -0000
@@ -530,12 +530,12 @@
for (i = 0; i < numoptions; i++)
{
- if (!options[i]->isset)
- continue;
-
if (pg_strncasecmp(options[i]->name, "fillfactor", options[i]->namelen) == 0)
{
- lopts.fillfactor = ((relopt_int *) options[i])->parsed_val;
+ if (options[i]->isset)
+ lopts.fillfactor = ((relopt_int *) options[i])->parsed_val;
+ else
+ lopts.fillfactor = ((relopt_int *) options[i])->default_val;
break;
}
}
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
