What I ifind interesting about this is that whereas I had been concerned that adding hot standby late in the development cycle might be destabilize the tree and add lots of time to the release cycle it seems having it might actually increase our ability to see problems in the recovery code which was previously quite hard to test.

--
Greg


On 4 Jan 2009, at 09:59, Heikki Linnakangas <heikki.linnakan...@enterprisedb.com > wrote:

Heikki Linnakangas wrote:
I can reproduce that too with CVS HEAD, so it's clearly a bug. I probably introduced it with the recent smgr changes; I'll try to hunt it down.

Now that was an embarrassingly simple bug:

--- a/src/backend/catalog/storage.c
+++ b/src/backend/catalog/storage.c
@@ -106,7 +106,7 @@ RelationCreateStorage(RelFileNode rnode, bool istemp)
   srel = smgropen(rnode);
   smgrcreate(srel, MAIN_FORKNUM, false);

-    if (istemp)
+    if (!istemp)
   {
       /*
* Make an XLOG entry showing the file creation. If we abort, the file

Fixed, as well as the same bug in RelationTruncate. Thanks for report, I'll keep this brown paper bag on for a few days...

--
 Heikki Linnakangas
 EnterpriseDB   http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to