> I think at a minimum there should be a manual configuration switch > (ie something in pg_config_manual.h) to allow the builder to disable > use of posix_fadvise, even if configure thinks it's there. Depending > on buildfarm results we may have to do more than that.
This seems pretty pointless, since there is already a GUC to control the behavior, and the default is off. The only value here would be if you could demonstrate that even with effective_io_concurrency set to 1 there is a significant performance dropoff. But that would probably be an argument for rejecting the patch outright, not adding a compile-time switch. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
