When we have now collation per database I think following comment is
useless:

* (2) this code is executed in the postmaster, so the setlocale() will
* propagate to forked backends, which aren't going to read this file for
* themselves.   (These locale settings are considered critical
* compatibility items because they can affect sort order of indexes.)


Patch attached.

                Zdenek
*** pgsql.orig.1f40b253cd5f/src/backend/access/transam/xlog.c	2009-02-07 10:04:18.526406897 +0100
--- /export/home/zk200664/work/mercurial/pgsql.orig/src/backend/access/transam/xlog.c	2009-02-07 10:03:41.167554240 +0100
***************
*** 4045,4059 ****
  				(errmsg("incorrect checksum in control file")));
  
  	/*
! 	 * Do compatibility checking immediately.  We do this here for 2 reasons:
  	 *
  	 * (1) if the database isn't compatible with the backend executable, we
  	 * want to abort before we can possibly do any damage;
  	 *
- 	 * (2) this code is executed in the postmaster, so the setlocale() will
- 	 * propagate to forked backends, which aren't going to read this file for
- 	 * themselves.	(These locale settings are considered critical
- 	 * compatibility items because they can affect sort order of indexes.)
  	 */
  	if (ControlFile->catalog_version_no != CATALOG_VERSION_NO)
  		ereport(FATAL,
--- 4045,4055 ----
  				(errmsg("incorrect checksum in control file")));
  
  	/*
! 	 * Do compatibility checking immediately.  We do this here for 1 reason:
  	 *
  	 * (1) if the database isn't compatible with the backend executable, we
  	 * want to abort before we can possibly do any damage;
  	 *
  	 */
  	if (ControlFile->catalog_version_no != CATALOG_VERSION_NO)
  		ereport(FATAL,
-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to