Andrew Dunstan <and...@dunslane.net> writes:
> + void
> + init_dump_utils()

This should be
> + void
> + init_dump_utils(void)

please.  We don't do K&R C around here.  I'd lose the added retval
variable too; that's not contributing anything.

> ! #endif;

Semicolon is bogus here.

Looks pretty sane otherwise.

                        regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to