Tom Lane wrote: > As of CVS HEAD, I see that we got rid of that, and pg_trace.h is now > included only by the .c files that actually need it. ISTM that we > should make 8.3 do likewise.
Here's a patch for this. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Index: src/backend/access/transam/xact.c =================================================================== RCS file: /home/alvherre/Code/cvs/pgsql/src/backend/access/transam/xact.c,v retrieving revision 1.257.2.2 diff -c -p -r1.257.2.2 xact.c *** src/backend/access/transam/xact.c 26 Apr 2008 23:35:33 -0000 1.257.2.2 --- src/backend/access/transam/xact.c 10 Mar 2009 23:02:58 -0000 *************** *** 33,38 **** --- 33,39 ---- #include "executor/spi.h" #include "libpq/be-fsstubs.h" #include "miscadmin.h" + #include "pg_trace.h" #include "pgstat.h" #include "storage/fd.h" #include "storage/lmgr.h" Index: src/backend/storage/lmgr/lock.c =================================================================== RCS file: /home/alvherre/Code/cvs/pgsql/src/backend/storage/lmgr/lock.c,v retrieving revision 1.181.2.1 diff -c -p -r1.181.2.1 lock.c *** src/backend/storage/lmgr/lock.c 4 Mar 2008 19:54:13 -0000 1.181.2.1 --- src/backend/storage/lmgr/lock.c 10 Mar 2009 23:04:22 -0000 *************** *** 36,41 **** --- 36,42 ---- #include "access/twophase.h" #include "access/twophase_rmgr.h" #include "miscadmin.h" + #include "pg_trace.h" #include "pgstat.h" #include "utils/memutils.h" #include "utils/ps_status.h" Index: src/backend/storage/lmgr/lwlock.c =================================================================== RCS file: /home/alvherre/Code/cvs/pgsql/src/backend/storage/lmgr/lwlock.c,v retrieving revision 1.50 diff -c -p -r1.50 lwlock.c *** src/backend/storage/lmgr/lwlock.c 1 Jan 2008 19:45:52 -0000 1.50 --- src/backend/storage/lmgr/lwlock.c 10 Mar 2009 23:04:42 -0000 *************** *** 25,30 **** --- 25,31 ---- #include "access/multixact.h" #include "access/subtrans.h" #include "miscadmin.h" + #include "pg_trace.h" #include "storage/ipc.h" #include "storage/proc.h" #include "storage/spin.h" Index: src/include/c.h =================================================================== RCS file: /home/alvherre/Code/cvs/pgsql/src/include/c.h,v retrieving revision 1.222.2.1 diff -c -p -r1.222.2.1 c.h *** src/include/c.h 23 Feb 2008 19:11:55 -0000 1.222.2.1 --- src/include/c.h 10 Mar 2009 23:01:54 -0000 *************** *** 57,63 **** #include "pg_config_os.h" /* must be before any system header files */ #endif #include "postgres_ext.h" - #include "pg_trace.h" #if _MSC_VER >= 1400 #define errcode __msvc_errcode --- 57,62 ----
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
