Fujii Masao wrote:
On Fri, May 15, 2009 at 8:20 PM, Heikki Linnakangas
<heikki.linnakan...@enterprisedb.com> wrote:
The probe in findNewestTimeLine() initialized to recovery target timeline +
1. It doesn't require history files for any old timelines to be present.

What if recovery_target_timeline = 'latest'? The unexpected (not latest)
recovery target timeline might be chosen when some timeline history
files don't exist.

The
purpose of findNewestTimeLine() is to ensure that if you e.g recover to a
point in time in timeline 5, and there's already WAL files for timelines 6
and 7 in the archive, we pick a unique timeline id.

When only the history file for timeline 6 is deleted, timeline 6 would be
assigned as the newest one *again* at the end of archive recovery.
Is this safe?

If you delete history file and all the WAL for timeline 6, yeah, nothing stops it from being reused. It will work just fine, as if it never existed. If you still have the history file and WAL for the old timeline 6 lying around somewhere else like an older offsite backup, it's easy for the administrator to get confused, but there isn't much we can do about that.

Simon's idea of keeping a copy of all the history files in the data directory wouldn't help here. In fact, I think we already never delete history files in the server, it's just that if you omit the pg_xlog directory in the base backup they won't be included. But even if they are included in the base backup, that wouldn't help in this scenario because the base backup still wouldn't contain the history files for the later timelines.

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to