On Mon, May 25, 2009 at 11:27:27AM -0400, Tom Lane wrote: > Oh, right, that was Bruce's "improvement" of the COPY code. I was less > than thrilled with it, but didn't have an easy alternative. > > You can't just remove the "else", or it's unsafe; and I'm afraid that
But why? What does this empty else accomplish? I'd like to understand the need for it. > changing the macros into "else {}" would still leave us with some > warnings about empty statements ... Hmm, apparently no, at least not on my gcc 4.3. As soon as I add the empty braces, the warning is gone. But without really understanding the need for this I certainly don't want to make that change. Maybe Bruce can comment. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: mes...@jabber.org Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL! -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers