On Fri, Jul 3, 2009 at 5:49 PM, Joshua D. Drake<j...@commandprompt.com> wrote: > On Fri, 2009-07-03 at 16:54 -0400, Tom Lane wrote: >> Peter Eisentraut <pete...@gmx.net> writes: >> > And please make "Delete Patch" into a button instead of a link. >> >> Only if there's some kind of confirmation ... > > Should we actually delete patches? I get removing them from the list but > it seems there could be benefit from keeping patches that are not > "quite" there or perhaps present an idea that is ahead of its time (or > half baked but interesting in genera?). > > +1 on the confirmation regardless.
There is a confirmation right now, plus it doesn't work at all unless you delete all the comments first, which you can't do either unless you are an administrator or the only person who has ever commented on the patch. Really, deleting patches should be quite rare and only needed in cases where the patch should not have been added in the first place. I guess I'm not really seeing why that particular thing should be a button rather than a link. It would mess up the formatting for no obvious benefit. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
