On Wed, Jul 15, 2009 at 11:44 PM, Alex Hunsaker<bada...@gmail.com> wrote: > On Mon, Dec 8, 2008 at 06:56, Pavan Deolasee<pavan.deola...@gmail.com> wrote: >> Here is a patch which implements this. The PD_ALL_VISIBLE flag is set if all >> tuples in the page are visible to all transactions and there are no DEAD >> line pointers in the page. The second check is required so that VACUUM takes >> up the page. We could slightly distinguish the two cases (one where the page >> requires vacuuming only because of DEAD line pointers and the other where >> the page-tuples do not require any visibility checks), but I thought its not >> worth the complexity. > > Hi! > > I was round robin assigned to review this. So take my comments with > the grain of salt (or novice HOT salt) they deserve.
Pavan, are you planning to respond to Alex's comments and/or update this patch? ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
