2009/7/30 Euler Taveira de Oliveira <eu...@timbira.com>: >> So if you put the test inside the switch, it would need to appear in >> every single branch of the switch except for the NUM_E one. I'm >> confused about why you think this needs a comment. Perhaps I >> misunderstood you? >> > Yes, I know you need to modify every 'case' clause to test if EEEE was > previously used (that was one suggestion) but I said if you don't want to go > that way, add a comment explaining why you're using that 'if' above the > 'switch' and not inside it. >
I think we've pretty much reached an impasse on this one. I can't imagine anyone reading the code getting confused about this, and don't know how to go about writing a comment explaining something that is intuitively obvious to me. I don't understand what aspect of it requires explanation. The test is not in the switch because it doesn't belong there. Perhaps someone else could weigh in and help us to resolve this? Cheers, BJ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
