Tom Lane wrote: > Greg Stark <gsst...@mit.edu> writes: > > On Tue, Aug 4, 2009 at 12:18 AM, Tom Lane<t...@sss.pgh.pa.us> wrote: > >> One other stylistic gripe: I don't much like inserting a GUC variable > >> definition into builtins.h --- that file has traditionally only > >> contained function extern declarations. �The best alternative I can > >> think of is to move the bytea-related stuff into a new include file > >> include/utils/bytea.h. �Has anyone got an objection or a better idea? > > > The other guc that controls default i/o formats for a data type is > > DateStyle. I can't say I expected to find that in miscadmin.h though. > > Perhaps move both of them into a utils/adt.h or something like that? > > Hmm, actually now that you mention it there's a bunch of GUC variables > in miscadmin.h. Surprise factor aside, I'm inclined to just shove > bytea_output in there along with DateStyle/IntervalStyle/etc.
I vote for a new bytea.h file that does not slurp in byteain/byteaout, to avoid breaking 3rd party code. miscadmin.h seems the worst solution, since it's already included in 210 other files. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Index: src/pl/plpgsql/src/pl_exec.c =================================================================== RCS file: /home/alvherre/Code/cvs/pgsql/src/pl/plpgsql/src/pl_exec.c,v retrieving revision 1.246 diff -c -p -r1.246 pl_exec.c *** src/pl/plpgsql/src/pl_exec.c 22 Jul 2009 02:31:38 -0000 1.246 --- src/pl/plpgsql/src/pl_exec.c 4 Aug 2009 01:00:06 -0000 *************** *** 23,28 **** --- 23,29 ---- #include "executor/spi_priv.h" #include "funcapi.h" #include "lib/stringinfo.h" + #include "miscadmin.h" #include "nodes/nodeFuncs.h" #include "parser/scansup.h" #include "storage/proc.h" Index: src/pl/plpgsql/src/pl_handler.c =================================================================== RCS file: /home/alvherre/Code/cvs/pgsql/src/pl/plpgsql/src/pl_handler.c,v retrieving revision 1.44 diff -c -p -r1.44 pl_handler.c *** src/pl/plpgsql/src/pl_handler.c 18 Feb 2009 11:33:04 -0000 1.44 --- src/pl/plpgsql/src/pl_handler.c 4 Aug 2009 00:59:54 -0000 *************** *** 18,23 **** --- 18,24 ---- #include "catalog/pg_proc.h" #include "catalog/pg_type.h" #include "funcapi.h" + #include "miscadmin.h" #include "utils/builtins.h" #include "utils/guc.h" #include "utils/lsyscache.h" Index: src/pl/plpgsql/src/plpgsql.h =================================================================== RCS file: /home/alvherre/Code/cvs/pgsql/src/pl/plpgsql/src/plpgsql.h,v retrieving revision 1.114 diff -c -p -r1.114 plpgsql.h *** src/pl/plpgsql/src/plpgsql.h 22 Jul 2009 02:31:38 -0000 1.114 --- src/pl/plpgsql/src/plpgsql.h 4 Aug 2009 00:59:06 -0000 *************** *** 20,26 **** #include "access/xact.h" #include "fmgr.h" - #include "miscadmin.h" #include "commands/trigger.h" #include "executor/spi.h" #include "utils/tuplestore.h" --- 20,25 ----
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
