On Sun, Aug 2, 2009 at 3:05 PM, Jeff Davis<pg...@j-davis.com> wrote: > The patch looks good. > > Comments: > > 1. The docs should be clarified a little. For instance, it should have a > link back to the definition of a prefix search (12.3.2). I included my > doc suggestions as an attachment. > > 2. dsynonym_init() uses findwrd() in a slightly confusing (and perhaps > fragile) way. After calling findwrd(), the "end" pointer is pointing at > either the end of the string, or the *; depending on whether the string > ends in * and whether flags is NULL. I only mention this because I had > to take a more careful look to see what was happening. Perhaps add a > comment to make it more clear? > > 3. The patch looks for the special byte '*'. I think that's fine, > because we depend on the files being in UTF-8 encoding, where it's the > same byte. However, I thought it was worth mentioning in case we want to > support other encodings for text search files later.
Oleg, Are you planning to update this patch this week? If not I will set it to "Returned with Feedback". Thanks, ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
