(resent to -hackers)
I just applied and tested the new patch. Everything works great.
The only thing I would change now is some of the comments.
1). On line 289, one of the regression test comments got copied:
+ move forward in c; --should be at '5'
change to:
+ move forward in c; --should be at '1'
2). Lines 79/80:
+
errmsg("statement FETCH returns more rows."),
+
errhint("Multirows fetch are not allowed in PL/pgSQL.")));
This might sound better as "statement FETCH returns multiple rows.",
and "Multirow FETCH is not allowed in PL/pgSQL."
Everything else looks good to me.
John
> Hi Selena and John,
>
> Pavel's latest patch seems to address all the issues you raised in
> your initial review. Do you have any comments on this new revision?
> If you're happy that your issues have been resolved, please mark the
> patch as Ready for Committer.
>
> Cheers,
> BJ
>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
