>>>>> "Tom" == Tom Lane <t...@sss.pgh.pa.us> writes:

 Tom> I think you could probably just change it: make DISTINCT work as
 Tom> per regular DISTINCT (treat null like a value, keep one copy).
 Tom> All the spec-conforming aggregates are strict and would ignore
 Tom> the null in the next step anyway.

 >> Change it for single-arg DISTINCT too? And the resulting change to the
 >> established behaviour of array_agg is acceptable? Just want to be clear
 >> here.

 Tom> I doubt that very many people are depending on the behavior of
 Tom> array_agg(DISTINCT); and anyway it could be argued that the
 Tom> present behavior is a bug, since it doesn't work like standard
 Tom> DISTINCT.  I don't see a problem with changing it, though it
 Tom> should be release-noted.

A followup question: currently the code uses the "datum" interface for
tuplesort. Obviously with multiple columns the slot interface is used
instead; but is there any performance advantage for staying with the
datum interface for the single-column case?

-- 
Andrew.

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to