Peter Eisentraut píše v po 30. 11. 2009 v 21:27 +0200: > On mån, 2009-11-30 at 19:53 +0100, Zdenek Kotala wrote: > > Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500: > > > I am not happy looking in a directory _above_ a specified directory by > > > default: > > > > > > [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH]) > > > > > > That seems possibly unsafe. I suggest you just add it to the PATH for > > > Solaris builds. > > > > I'm not sure if it is unsafer that searching in $PATH. Anyway I don't > > think that your proposed solution is good way. I'm able to do it but how > > many other people can? Who know where collateindex.pl stays on Solaris? > > configure is here to make live easier for people. If we know how to do > > it automatically we should do it. > > Note that $DOCBOOKSTYLE/bin corresponds to the location of the file in > an unpacked source archive and $PATH is of course where programs > normally go. The $DOCBOOKSTYLE/.. location makes no sense at all, > because that basically says that the installer intentionally moved the > file, but to a completely nonstandard location.
I'm not sgml//docbook guru. Do you think that Solaris location of collateindex.pl is wrong? Does exist any recommendation for this? I could log a bug, but I need some link with recommendation. > > If you think that $DOCBOOKSTYLE/.. is not good than I propose to > > use /usr/share/sgml/docbook/ directly. > > That would be the less ugly solution. Patch attached. thanks Zdenek
diff -r 2d87758e836b config/docbook.m4 --- a/config/docbook.m4 Sun Nov 22 22:06:30 2009 +0000 +++ b/config/docbook.m4 Mon Nov 30 20:55:15 2009 +0100 @@ -93,7 +93,7 @@ [AC_REQUIRE([PGAC_PATH_DOCBOOK_STYLESHEETS])dnl if test -n "$DOCBOOKSTYLE"; then AC_PATH_PROGS(COLLATEINDEX, collateindex.pl, [], - [$DOCBOOKSTYLE/bin $PATH]) + [$DOCBOOKSTYLE/bin /usr/share/sgml/docbook $PATH]) else AC_PATH_PROGS(COLLATEINDEX, collateindex.pl) fi])# PGAC_PATH_COLLATEINDEX
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers