Kevin Grittner wrote:
http://wiki.postgresql.org/wiki/Running_a_CommitFest
It seems to me that a patch could move from "Discussing review" to
"Needs review" -- if the reviewer decided to discuss the approach
before continuing the review process and the discussion confirms the
approach as viable.
In that case, the patch would be in "Needs review" the whole time.
"Discussing review" is intended to be a "I'm done but not sure of the
next step for this patch" state the reviewer can use. In the situation
you described, the patch would never have left "Needs review". I just
made that more clear by documenting that it's shorthand for "discussing
review results".
I also added a transition path for a similar situation though, where the
discussion concludes the reviewer didn't do the right thing in the first
place (even though they thought they did) and they return to reviewing
after realizing what was missing.
--
Greg Smith 2ndQuadrant Baltimore, MD
PostgreSQL Training, Services and Support
g...@2ndquadrant.com www.2ndQuadrant.com
