Michael Paquier <michael.paqu...@gmail.com> wrote: > Yeah the grammar ":variable" is used to set a parameter, the user will feel > disorientated if there is no support. > The attached patch supports this new case, based on Itagaki-san's last > version.
What is the spec of "\setshell :variable" ? Literally interpreted, it declares a variable with name ":variable". But pgbench cannot use such variables because only variables named with alphabets, numbers, and _ can be accepted. Should we forbid to assign variables that name contain invalid characters instead? > I also added a warning to tell the user that pgbench is slowing > down when using this feature. This change seems to be nonsense. Do you want to fill your terminal with such messages? Proposed patch attached. It checks for variable names whether they consist of isalnum or _. The check is only performed when a new variable is assigned to avoid overhead. In normal workload, variables with the same names are re-used repeatedly. I don't think the additinal check would decrease performance of pgbench. Regards, --- Takahiro Itagaki NTT Open Source Software Center
pgbenchshell_20091215.patch
Description: Binary data
pgbenchshell_test.sql
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
