On Fri, Dec 18, 2009 at 9:48 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> Oh. This is more complicated than it appeared on the surface. It >> seems that the string "BLOB COMMENTS" actually gets inserted into >> custom dumps somewhere, so I'm not sure whether we can just change it. >> Was this issue discussed at some point before this was committed? >> Changing it would seem to require inserting some backward >> compatibility code here. Another option would be to add a separate >> section for "BLOB METADATA", and leave "BLOB COMMENTS" alone. Can >> anyone comment on what the Right Thing To Do is here? > > The BLOB COMMENTS label is, or was, correct for what it contained. > If this patch has usurped it to contain other things
It has. > I would argue > that that is seriously wrong. pg_dump already has a clear notion > of how to handle ACLs for objects. ACLs for blobs ought to be > made to fit into that structure, not dumped in some random place > because that saved a few lines of code. OK. Hopefully KaiGai or Takahiro can suggest a fix. Thanks, ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
