Robert Haas escribió: > The fastgetattr() attempts to make provision for the case where isnull > is a NULL pointer, but it doesn't seem to work. I tried it and got: > > relcache.c:494: error: invalid use of void expression > relcache.c:494: error: invalid use of void expression > relcache.c:494: warning: left-hand operand of comma expression has no effect > relcache.c:494: warning: left-hand operand of comma expression has no effect > > Changing the fourth argument from NULL to &isnull made the problem go away. > > I think we should either fix this so it actually works (if that's even > possible), or rip out the code that tries to cope with it.
+1 for removing it. I used that macro as a pattern to write some other macro to which I tried to pass a NULL value and wasted at least a couple of hours trying to figure out why it wasn't working. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
