On Sun, Jan 10, 2010 at 13:44, Magnus Hagander <mag...@hagander.net> wrote: > On Sun, Jan 10, 2010 at 13:33, James Mansion > <ja...@mansionfamily.plus.com> wrote: >> Tom Lane wrote: >>> >>> There's another copy of ListenSocket[] in the BackendParameters struct. >>> I also wonder about postmaster.c's habit of using -1 for empty slots >>> in ListenSocket ... how safe is that for Win64? >>> >> >> On Windows, it should be INVALID_SOCKET. > > Indeed it should, but I think we're Ok anyway. Here's the extract from > the SDK headers. > > /* > * This is used instead of -1, since the > * SOCKET type is unsigned. > */ > #define INVALID_SOCKET (SOCKET)(~0) > #define SOCKET_ERROR (-1) > > > But it might be worthwhile going across all those places and setting > them to PGINVALID_SOCKET, and typedef that as well.
That was pretty easy, provided I didn't miss too many places :-) So I did that, and applied. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
