2010/1/12 Takahiro Itagaki <itagaki.takah...@oss.ntt.co.jp>: > Hi, I'm reviewing OPEN FOR EXECUTE USING patch and have a couple of > trivial comments. > > Pavel Stehule <pavel.steh...@gmail.com> wrote: > >> this small patch add missing USING clause to OPEN FOR EXECUTE statement >> + cleaning part of exec_stmt_open function > > - Can we use read_sql_expression2() instead of read_sql_construct() > in gram.y? It could simplify the code a bit. > > - I'd prefer to change the new argument for exec_dynquery_with_params() > from "char *portalname" to "const char *curname". >
ok, I accept all comments. revised version are attached. Thank you, Pavel Stehule > Other than the above minor issues, this patch is ready to commit. > > Regards, > --- > Takahiro Itagaki > NTT Open Source Software Center > > >
openexecusing-after-rev.diff
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
