There is something slightly funny about the regression test output.
When it starts a parallel group, it prints something like
parallel group (14 tests): select_views portals_p2 rules foreign_key
cluster dependency guc bitmapops combocid tsearch tsdicts foreign_data
window xmlmap
One would think that it prints this as the tests are started, but it
actually prints it as the tests finish. The last one or two test names
are always printed after a considerable delay, probably because of
terminal timing issues, which I have found confusing on several
occasions.
Note also that that behavior is inconsistent with that of a serial test
like
test misc ... ok
Here, the first part of the line is printed before that test starts, and
the result is printed after.
I propose to adjust the behavior so that the "parallel group" line
prints the test names before/as the tests are started, and then the
subsequent lines print the results after the tests finish, as is
currently the case.
See attached patch.
Index: pg_regress.c
===================================================================
RCS file: /cvsroot/pgsql/src/test/regress/pg_regress.c,v
retrieving revision 1.69
diff -u -3 -p -r1.69 pg_regress.c
--- pg_regress.c 2 Jan 2010 16:58:15 -0000 1.69
+++ pg_regress.c 17 Jan 2010 20:18:21 -0000
@@ -1392,8 +1392,6 @@ wait_for_tests(PID_TYPE * pids, int *sta
#endif
pids[i] = INVALID_PID;
statuses[i] = (int) exit_status;
- if (names)
- status(" %s", names[i]);
tests_left--;
break;
}
@@ -1565,6 +1563,7 @@ run_schedule(const char *schedule, test_
tests + oldest, i - oldest);
oldest = i;
}
+ status(" %s", tests[i]);
pids[i] = (tfunc) (tests[i], &resultfiles[i], &expectfiles[i], &tags[i]);
}
wait_for_tests(pids + oldest, statuses + oldest,
@@ -1576,6 +1575,7 @@ run_schedule(const char *schedule, test_
status(_("parallel group (%d tests): "), num_tests);
for (i = 0; i < num_tests; i++)
{
+ status(" %s", tests[i]);
pids[i] = (tfunc) (tests[i], &resultfiles[i], &expectfiles[i], &tags[i]);
}
wait_for_tests(pids, statuses, tests, num_tests);
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
