Fujii Masao wrote: > On Wed, Jan 27, 2010 at 7:05 PM, Heikki Linnakangas > <[email protected]> wrote: >> Before that, endptr is advanced using XLByteAdvance() macro, which does >> handle xlogid boundaries. Is XLByteAdvance() broken? > > No. The cause of the bug is that endptr might be set to the SendRqstPtr > that has crossed a xlogid boundary in the following code. > >> /* if we went beyond SendRqstPtr, back off */ >> if (XLByteLT(SendRqstPtr, endptr)) >> endptr = SendRqstPtr;
But SendRqstPtr comes from LogwrtResult.Write, surely that's correct, no? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
